From: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Tue, 18 Dec 2007 12:22:15 +0100 Subject: [lockdep] make cli/sti annotation warnings clearer Message-id: 20071218112316.527976190@chello.nl O-Subject: [RHEL5.2 PATCH 14/14] lockdep: make cli/sti annotation warnings clearer Bugzilla: 193729 make cli/sti annotation warnings easier to interpret. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> diff --git a/kernel/lockdep.c b/kernel/lockdep.c index 984e1e3..805a249 100644 --- a/kernel/lockdep.c +++ b/kernel/lockdep.c @@ -2516,10 +2516,15 @@ static void check_flags(unsigned long flags) if (!debug_locks) return; - if (irqs_disabled_flags(flags)) - DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled); - else - DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled); + if (irqs_disabled_flags(flags)) { + if (DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)) { + printk("possible reason: unannotated irqs-off.\n"); + } + } else { + if (DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled)) { + printk("possible reason: unannotated irqs-on.\n"); + } + } /* * We dont accurately track softirq state in e.g.