From 67e4b7e64209029f07a0e451ff97572f84ea4c55 Mon Sep 17 00:00:00 2001 From: Jan Kiszka <jan.kiszka@siemens.com> Date: Mon, 26 Jan 2009 18:52:44 +0100 Subject: [PATCH 64/70] kvm: qemu: Remove eflags conversion into emulator format It seems that the conversion of the kernel-delivered eflags state into qemu's internal splitted representation was once needed in an older kvm design (register read-back may have taken place from inside cpu_exec). Today it is plain wrong and causes incorrect cpu state reporting (gdb, monitor) and should also corrupt its saving (savevm, migration). Drop the corresponding lines. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> RH-Upstream-status: applied(kvm/master) Acked-by: Marcelo Tosatti <mtosatti@redhat.com> --- qemu/qemu-kvm-x86.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/qemu/qemu-kvm-x86.c b/qemu/qemu-kvm-x86.c index 4fad2af..cbb90f2 100644 --- a/qemu/qemu-kvm-x86.c +++ b/qemu/qemu-kvm-x86.c @@ -427,10 +427,6 @@ void kvm_arch_save_regs(CPUState *env) } } env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags; - env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); - env->df = 1 - (2 * ((env->eflags >> 10) & 1)); - env->cc_op = CC_OP_EFLAGS; - env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); /* msrs */ n = 0; -- 1.6.1