From ea2d98074f38b829702933da59923937c83ae428 Mon Sep 17 00:00:00 2001 From: Glauber Costa <glommer@redhat.com> Date: Tue, 26 May 2009 11:11:56 -0400 Subject: [PATCH 02/10] introduce set_rate_limit function for QEMUFile This patch converts the current callers of qemu_fopen_ops(). Signed-off-by: Glauber Costa <glommer@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> RH-Upstream-status: upstream (qemu/master) Message-Id: <1243350717-13012-3-git-send-email-glommer@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <1243352661-13226-3-git-send-email-glommer@redhat.com> Acked-by: Dor Laor <dlaor@redhat.com> Acked-by: Juan Quintela <quintela@redhat.com> Acked-by: Uri Lublin <uril@redhat.com> Bugzilla: 504237 --- qemu/buffered_file.c | 16 +++++++++++++++- qemu/hw/hw.h | 10 +++++++++- qemu/savevm.c | 27 +++++++++++++++++++-------- 3 files changed, 43 insertions(+), 10 deletions(-) diff --git a/qemu/buffered_file.c b/qemu/buffered_file.c index be5baea..4f11544 100644 --- a/qemu/buffered_file.c +++ b/qemu/buffered_file.c @@ -198,6 +198,19 @@ static int buffered_rate_limit(void *opaque) return 0; } +static size_t buffered_set_rate_limit(void *opaque, size_t new_rate) +{ + QEMUFileBuffered *s = opaque; + + if (s->has_error) + goto out; + + s->xfer_limit = new_rate / 10; + +out: + return s->xfer_limit; +} + static void buffered_rate_tick(void *opaque) { QEMUFileBuffered *s = opaque; @@ -239,7 +252,8 @@ QEMUFile *qemu_fopen_ops_buffered(void *opaque, s->close = close; s->file = qemu_fopen_ops(s, buffered_put_buffer, NULL, - buffered_close, buffered_rate_limit); + buffered_close, buffered_rate_limit, + buffered_set_rate_limit); s->timer = qemu_new_timer(rt_clock, buffered_rate_tick, s); diff --git a/qemu/hw/hw.h b/qemu/hw/hw.h index 2d3ce4c..b993364 100644 --- a/qemu/hw/hw.h +++ b/qemu/hw/hw.h @@ -29,10 +29,17 @@ typedef int (QEMUFileCloseFunc)(void *opaque); */ typedef int (QEMUFileRateLimit)(void *opaque); +/* Called to change the current bandwidth allocation. This function must return + * the new actual bandwidth. It should be new_rate if everything goes ok, and + * the old rate otherwise + */ +typedef size_t (QEMUFileSetRateLimit)(void *opaque, size_t new_rate); + QEMUFile *qemu_fopen_ops(void *opaque, QEMUFilePutBufferFunc *put_buffer, QEMUFileGetBufferFunc *get_buffer, QEMUFileCloseFunc *close, - QEMUFileRateLimit *rate_limit); + QEMUFileRateLimit *rate_limit, + QEMUFileSetRateLimit *set_rate_limit); QEMUFile *qemu_fopen(const char *filename, const char *mode); QEMUFile *qemu_fopen_socket(int fd); QEMUFile *qemu_popen(FILE *popen_file, const char *mode); @@ -66,6 +73,7 @@ unsigned int qemu_get_be16(QEMUFile *f); unsigned int qemu_get_be32(QEMUFile *f); uint64_t qemu_get_be64(QEMUFile *f); int qemu_file_rate_limit(QEMUFile *f); +size_t qemu_file_set_rate_limit(QEMUFile *f, size_t new_rate); int qemu_file_has_error(QEMUFile *f); void qemu_file_set_has_error(QEMUFile *f); diff --git a/qemu/savevm.c b/qemu/savevm.c index 8c003f9..bc2652a 100644 --- a/qemu/savevm.c +++ b/qemu/savevm.c @@ -155,6 +155,7 @@ struct QEMUFile { QEMUFileGetBufferFunc *get_buffer; QEMUFileCloseFunc *close; QEMUFileRateLimit *rate_limit; + QEMUFileSetRateLimit *set_rate_limit; void *opaque; int is_write; @@ -239,9 +240,9 @@ QEMUFile *qemu_popen(FILE *popen_file, const char *mode) s->popen_file = popen_file; if(mode[0] == 'r') { - s->file = qemu_fopen_ops(s, NULL, popen_get_buffer, popen_close, NULL); + s->file = qemu_fopen_ops(s, NULL, popen_get_buffer, popen_close, NULL, NULL); } else { - s->file = qemu_fopen_ops(s, popen_put_buffer, NULL, popen_close, NULL); + s->file = qemu_fopen_ops(s, popen_put_buffer, NULL, popen_close, NULL, NULL); } fprintf(stderr, "qemu_popen: returning result of qemu_fopen_ops\n"); return s->file; @@ -267,7 +268,7 @@ QEMUFile *qemu_fopen_socket(int fd) return NULL; s->fd = fd; - s->file = qemu_fopen_ops(s, NULL, socket_get_buffer, socket_close, NULL); + s->file = qemu_fopen_ops(s, NULL, socket_get_buffer, socket_close, NULL, NULL); return s->file; } @@ -313,9 +314,9 @@ QEMUFile *qemu_fopen(const char *filename, const char *mode) goto fail; if (!strcmp(mode, "wb")) - return qemu_fopen_ops(s, file_put_buffer, NULL, file_close, NULL); + return qemu_fopen_ops(s, file_put_buffer, NULL, file_close, NULL, NULL); else if (!strcmp(mode, "rb")) - return qemu_fopen_ops(s, NULL, file_get_buffer, file_close, NULL); + return qemu_fopen_ops(s, NULL, file_get_buffer, file_close, NULL, NULL); fail: if (s->outfile) @@ -363,15 +364,16 @@ static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int64_t offset, int is_wr s->base_offset = offset; if (is_writable) - return qemu_fopen_ops(s, block_put_buffer, NULL, bdrv_fclose, NULL); + return qemu_fopen_ops(s, block_put_buffer, NULL, bdrv_fclose, NULL, NULL); - return qemu_fopen_ops(s, NULL, block_get_buffer, bdrv_fclose, NULL); + return qemu_fopen_ops(s, NULL, block_get_buffer, bdrv_fclose, NULL, NULL); } QEMUFile *qemu_fopen_ops(void *opaque, QEMUFilePutBufferFunc *put_buffer, QEMUFileGetBufferFunc *get_buffer, QEMUFileCloseFunc *close, - QEMUFileRateLimit *rate_limit) + QEMUFileRateLimit *rate_limit, + QEMUFileSetRateLimit *set_rate_limit) { QEMUFile *f; @@ -384,6 +386,7 @@ QEMUFile *qemu_fopen_ops(void *opaque, QEMUFilePutBufferFunc *put_buffer, f->get_buffer = get_buffer; f->close = close; f->rate_limit = rate_limit; + f->set_rate_limit = set_rate_limit; f->is_write = 0; return f; @@ -561,6 +564,14 @@ int qemu_file_rate_limit(QEMUFile *f) return 0; } +size_t qemu_file_set_rate_limit(QEMUFile *f, size_t new_rate) +{ + if (f->set_rate_limit) + return f->set_rate_limit(f->opaque, new_rate); + + return 0; +} + void qemu_put_be16(QEMUFile *f, unsigned int v) { qemu_put_byte(f, v >> 8); -- 1.6.3.rc4.29.g8146