Sophie

Sophie

distrib > Scientific%20Linux > 5x > x86_64 > media > main-src > by-pkgid > aadbe78a25743146bb784eee19f007c5 > files > 110

kvm-83-164.el5_5.9.src.rpm

From d03f1a4d687cfacb63b8cf6a166890f7b3fd529c Mon Sep 17 00:00:00 2001
From: Glauber Costa <glommer@redhat.com>
Date: Wed, 10 Mar 2010 16:23:14 -0300
Subject: [PATCH] Fix Windows guests SVVP tests.

RH-Author: Glauber Costa <glommer@redhat.com>
Message-id: <1268238194-5699-1-git-send-email-glommer@redhat.com>
Patchwork-id: 7641
O-Subject: [PATCH] Fix Windows guests SVVP tests.
Bugzilla: 495844
RH-Acked-by: Rik van Riel <riel@redhat.com>
RH-Acked-by: Marcelo Tosatti <mtosatti@redhat.com>
RH-Acked-by: Zachary Amsden <zamsden@redhat.com>

Currently, the way we expose processor information in BIOS make us fail
SVVP for windows guests. The reason behind it, is that appearently,
Windows does not like to see CPUs marked as present (bit 0 in ACPI spec),
but not enabled (bit 1), which haunts SVVP.

One must note that, by taking this patch, we are essentially disabling cpu
hotplug for linux guests. Contrary to Windows, linux _expects_ cpus to be
present but not enable. This is the heuristics used by us to determine
that the cpu is hot-plugable. Neither are hurting the spec, since... there
is no spec for cpu hotplug.

So after this patch is applied, all cpus that are not in the system are
completely disabled, all bits cleared. For the system, it is like they never
existed.

RH-Bugzilla: 495844
RH-Upstream-status: N/A.
(Upstream does not commit to SVVP, so they don't have to make that choice)
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 bios/acpi-dsdt.dsl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 bios/acpi-dsdt.dsl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl
index 1ecbbc5..bd657b5 100755
--- a/bios/acpi-dsdt.dsl
+++ b/bios/acpi-dsdt.dsl
@@ -56,7 +56,7 @@ DefinitionBlock (
             }                                                               \
             Method (_STA) {                                                 \
                 If (CRST(nr)) { Return(0xF) }                               \
-                Else { Return(0x9) }                                        \
+                Else { Return(0x0) }                                        \
             }                                                               \
         }                                                                   \
 
-- 
1.6.3.rc4.29.g8146