From: Abhijith Das <adas@redhat.com> Date: Mon, 15 Sep 2008 08:54:06 -0500 Subject: [gfs2] panic if you misspell any mount options Message-id: 48CE68FE.5080108@redhat.com O-Subject: Re: [RHEL 5.3] GFS2: bz 231369 - GFS2 will panic if you misspell any mount options Bugzilla: 231369 RH-Acked-by: Steven Whitehouse <swhiteho@redhat.com> The gfs2 superblock pointer is NULL after a failed mount. When control eventually goes to gfs2_kill_sb, we dereference this NULL pointer. This patch ensures that the gfs2 superblock pointer is not NULL before being dereferenced in gfs2_kill_sb. Signed-off-by: Abhijith Das <adas@redhat.com> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index b6cff96..aa5f81c 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -1174,14 +1174,17 @@ static int gfs2_get_sb_meta(struct file_system_type *fs_type, int flags, static void gfs2_kill_sb(struct super_block *sb) { struct gfs2_sbd *sdp = sb->s_fs_info; - gfs2_meta_syncfs(sdp); - dput(sdp->sd_root_dir); - dput(sdp->sd_master_dir); - sdp->sd_root_dir = NULL; - sdp->sd_master_dir = NULL; + if (sdp) { + gfs2_meta_syncfs(sdp); + dput(sdp->sd_root_dir); + dput(sdp->sd_master_dir); + sdp->sd_root_dir = NULL; + sdp->sd_master_dir = NULL; + } shrink_dcache_sb(sb); kill_block_super(sb); - gfs2_delete_debugfs_file(sdp); + if (sdp) + gfs2_delete_debugfs_file(sdp); } struct file_system_type gfs2_fs_type = {