Sophie

Sophie

distrib > Scientific%20Linux > 5x > x86_64 > by-pkgid > 9383e745e23602bc45f9c92184feea59 > files > 63

gfs2-utils-0.1.62-28.el5.src.rpm

commit 27ddb92542bfa62d94e7e2496e717f84aaef53f6
Author: Bob Peterson <rpeterso@redhat.com>
Date:   Wed Feb 10 13:46:58 2010 -0600

    gfs2_edit savemeta: Don't release indirect buffers too soon
    
    This patch fixes a regression in the "gfs2_edit savemeta" command
    whereby system files such as journals were not being saved.
    The function that processes indirect block lists was releasing
    buffers in a fashion that works okay with the old buf.c
    assumptions but too soon for the new buf.c assumptions.
    
    rhbz#455300

diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c
index b630280..1b5c2c1 100644
--- a/gfs2/edit/savemeta.c
+++ b/gfs2/edit/savemeta.c
@@ -289,9 +289,7 @@ static void save_indirect_blocks(int out_fd, osi_list_t *cur_list,
 		}
 		if (height != hgt) { /* If not at max height */
 			nbh = bread(&sbd, indir_block);
-			osi_list_add_prev(&nbh->b_altlist,
-					  cur_list);
-			brelse(nbh);
+			osi_list_add_prev(&nbh->b_altlist, cur_list);
 		}
 	} /* for all data on the indirect block */
 }