From 194698b183828d0c722386eadae6d1a4620d8b1b Mon Sep 17 00:00:00 2001 From: Kevin Wolf <kwolf@redhat.com> Date: Tue, 11 May 2010 13:05:55 -0300 Subject: [PATCH 2/2] block: Fix bdrv_commit RH-Author: Kevin Wolf <kwolf@redhat.com> Message-id: <1273583155-8606-1-git-send-email-kwolf@redhat.com> Patchwork-id: 9182 O-Subject: [RHEL-5.6 KVM PATCH] block: Fix bdrv_commit Bugzilla: 587604 RH-Acked-by: Juan Quintela <quintela@redhat.com> RH-Acked-by: Christoph Hellwig <chellwig@redhat.com> RH-Acked-by: Naphtali Sprei <nsprei@redhat.com> Bugzilla: 587604 Upstream status: Submitted When reopening the image, don't guess the driver, but use the same driver as was used before. This is important if the format=... option was used for that image. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- qemu/block.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- qemu/block.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu/block.c b/qemu/block.c index fb6c657..59336a9 100644 --- a/qemu/block.c +++ b/qemu/block.c @@ -610,12 +610,12 @@ int bdrv_commit(BlockDriverState *bs) bdrv_delete(bs->backing_hd); bs->backing_hd = NULL; bs_rw = bdrv_new(""); - rw_ret = bdrv_open2(bs_rw, filename, open_flags | BDRV_O_RDWR, NULL); + rw_ret = bdrv_open2(bs_rw, filename, open_flags | BDRV_O_RDWR, drv); if (rw_ret < 0) { bdrv_delete(bs_rw); /* try to re-open read-only */ bs_ro = bdrv_new(""); - ret = bdrv_open2(bs_ro, filename, open_flags & ~BDRV_O_RDWR, NULL); + ret = bdrv_open2(bs_ro, filename, open_flags & ~BDRV_O_RDWR, drv); if (ret < 0) { bdrv_delete(bs_ro); /* drive not functional anymore */ @@ -658,7 +658,7 @@ ro_cleanup: bdrv_delete(bs->backing_hd); bs->backing_hd = NULL; bs_ro = bdrv_new(""); - ret = bdrv_open2(bs_ro, filename, open_flags & ~BDRV_O_RDWR, NULL); + ret = bdrv_open2(bs_ro, filename, open_flags & ~BDRV_O_RDWR, drv); if (ret < 0) { bdrv_delete(bs_ro); /* drive not functional anymore */ -- 1.7.0.3