From 61210c901b4a8a1535d8ef4f4b844facae4d93a1 Mon Sep 17 00:00:00 2001 From: Markus Armbruster <armbru@redhat.com> Date: Tue, 19 Apr 2011 15:10:20 -0300 Subject: [PATCH 08/10] atapi: GESN: Standardise event response handling for future additions RH-Author: Markus Armbruster <armbru@redhat.com> Message-id: <1303225822-22611-7-git-send-email-armbru@redhat.com> Patchwork-id: 22563 O-Subject: [PATCH RHEL5 qemu-kvm 6/8] atapi: GESN: Standardise event response handling for future additions Bugzilla: 652135 RH-Acked-by: Kevin Wolf <kwolf@redhat.com> RH-Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> RH-Acked-by: Amit Shah <amit.shah@redhat.com> Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah <amit.shah@redhat.com> Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> Acked-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Manually cherry-picked from qemu commit 0af63ba3629e6f826846a73636ca391a810b2c6e Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qemu/hw/ide.c | 25 +++++++++++++++++++------ 1 files changed, 19 insertions(+), 6 deletions(-) Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- qemu/hw/ide.c | 25 +++++++++++++++++++------ 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/qemu/hw/ide.c b/qemu/hw/ide.c index adae8d0..033ce62 100644 --- a/qemu/hw/ide.c +++ b/qemu/hw/ide.c @@ -1628,9 +1628,17 @@ static void handle_get_event_status_notification(IDEState *s, uint8_t control; } __attribute__((packed)) *gesn_cdb; - unsigned int max_len; + struct { + uint16_t len; + uint8_t notification_class; + uint8_t supported_events; + } __attribute((packed)) *gesn_event_header; + + unsigned int max_len, used_len; gesn_cdb = (void *)packet; + gesn_event_header = (void *)buf; + max_len = be16_to_cpu(gesn_cdb->len); /* It is fine by the MMC spec to not support async mode operations */ @@ -1641,12 +1649,17 @@ static void handle_get_event_status_notification(IDEState *s, return; } - /* polling */ + /* polling mode operation */ + /* We don't support any event class (yet). */ - cpu_to_ube16(buf, 0x00); /* No event descriptor returned */ - buf[2] = 0x80; /* No Event Available (NEA) */ - buf[3] = 0x00; /* Empty supported event classes */ - ide_atapi_cmd_reply(s, 4, max_len); + gesn_event_header->supported_events = 0; + + gesn_event_header->notification_class = 0x80; /* No event available */ + used_len = sizeof(*gesn_event_header); + + gesn_event_header->len = cpu_to_be16(used_len + - sizeof(*gesn_event_header)); + ide_atapi_cmd_reply(s, used_len, max_len); } static void ide_atapi_cmd(IDEState *s) -- 1.7.5.141.g791a