diff --git a/CMakeLists.txt b/CMakeLists.txt index eee9891..5c91e07 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -177,6 +177,7 @@ find_package(ZLIB REQUIRED) include(GNUInstallDirs) # Ensure rapidjson submodule is ready +if(FALSE) find_package(Git QUIET) if(GIT_FOUND AND EXISTS "${PROJECT_SOURCE_DIR}/.git") # Update submodules as needed @@ -212,7 +213,7 @@ if(VW_INSTALL) DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/rapidjson ) endif() - +endif() add_subdirectory(explore) add_subdirectory(cluster) diff --git a/vowpalwabbit/CMakeLists.txt b/vowpalwabbit/CMakeLists.txt index 92157c1..d2469ea 100644 --- a/vowpalwabbit/CMakeLists.txt +++ b/vowpalwabbit/CMakeLists.txt @@ -66,11 +66,7 @@ target_link_libraries(vw PUBLIC VowpalWabbit::explore VowpalWabbit::allreduce PRIVATE - Boost::program_options ${CMAKE_DL_LIBS} ${LINK_THREADS} ZLIB::ZLIB - # Workaround an issue where RapidJSON needed to be exported tom install the target. This is - # actually a private dependency and so do not "link" when processing targets for installation. - # https://gitlab.kitware.com/cmake/cmake/issues/15415 - $<BUILD_INTERFACE:rapidjson>) + Boost::program_options ${CMAKE_DL_LIBS} ${LINK_THREADS} ZLIB::ZLIB) add_library(VowpalWabbit::vw ALIAS vw)