From 8b29e8e7b321bbe102b3d543a7a5f20227371612 Mon Sep 17 00:00:00 2001
From: Hugo Lefeuvre <hle@debian.org>
Date: Fri, 27 Oct 2017 16:42:55 +0200
Subject: [PATCH 21/29] Un-define DEBUGSTACK (util/decompile.c)

pop(), peek() and co. are designed to crash whenever the stack becomes
NULL but this behavior is currently short-circuited by the DEBUGSTACK
option, a debug option which allows further processing when Stack == NULL.

With DEBUGSTACK defined, whenever the stack becomes NULL it is replaced
by a dummy element like "// *** pop(): INTERNAL STACK ERROR FOUND ***".

While this is an acceptable feature for debugging purposes, this is not
something we want for production because it may lead other functions to
crash (infinite loops, buffer over reads...) in an especially undebuggabble
way.
---
 util/decompile.c | 2 +-
 1 file changed, 1 insertions(+), 1 deletion(-)

diff --git a/util/decompile.c b/util/decompile.c
index a85a5eee..1593c9c0 100644
--- a/util/decompile.c
+++ b/util/decompile.c
@@ -20,7 +20,7 @@
 
 #define _GNU_SOURCE 1
 
-#define DEBUGSTACK
+//#define DEBUGSTACK
 #define DECOMP_SWITCH
 // #define DEBUGSWITCH
 
-- 
2.14.3