From b3268756f2681e28f1a85cf479a6bebb670daaff Mon Sep 17 00:00:00 2001 From: Pino Toscano <pino@kde.org> Date: Sun, 12 Feb 2017 01:00:33 +0100 Subject: [PATCH] unbreak K3bAudioMetainfoRenamerPluginWidget Commit cf01ff3159dbddb97e0e67246dee16441a64984a broke the custom file resolver for taglib, since the new object is deleted when the scope ends. A better solution needs to eventually be found, but for now better leak one object than crash using stale pointers. --- .../project/audiometainforenamer/k3baudiometainforenamerplugin.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/project/audiometainforenamer/k3baudiometainforenamerplugin.cpp b/plugins/project/audiometainforenamer/k3baudiometainforenamerplugin.cpp index 67567c7..1d67a06 100644 --- a/plugins/project/audiometainforenamer/k3baudiometainforenamerplugin.cpp +++ b/plugins/project/audiometainforenamer/k3baudiometainforenamerplugin.cpp @@ -46,7 +46,6 @@ #include <QtWidgets/QToolTip> #include <QtWidgets/QTreeWidget> #include <QtWidgets/QVBoxLayout> -#include <QSharedPointer> #include <taglib/tag.h> #include <taglib/fileref.h> @@ -150,8 +149,7 @@ K3bAudioMetainfoRenamerPluginWidget::K3bAudioMetainfoRenamerPluginWidget( K3b::D "<em>%n</em> (Track number), and <em>%t</em> (Title) " "are supported.") ); - QSharedPointer<K3bMimeTypeResolver> typePtr = QSharedPointer<K3bMimeTypeResolver>(new K3bMimeTypeResolver); - TagLib::FileRef::addFileTypeResolver(typePtr.data()); + TagLib::FileRef::addFileTypeResolver( new K3bMimeTypeResolver() ); }